flexera-public / rightscale_cookbooks

Other
76 stars 102 forks source link

fixed error in db_mysql::default_5_1 and db_mysql::default_5_5 where the platform was defined incorrectly #140

Closed jordtanner closed 12 years ago

ryanoleary commented 12 years ago

Hi Jord. Thanks for the pull request. In order for us to accept it, we need you to complete a Contributor Agreement. For details on the process, see here: http://support.rightscale.com/12-Guides/Chef_Cookbooks_Developer_Guide/08-Chef_Development/03-Contribute_to_RightScale_Cookbooks

If you have any questions, let me know. Thanks.

Ryan O'Leary Product Manager ryan.oleary@rightscale.com skype: ryan.oleary.rs phone: 805-243-0977

On Thu, Aug 2, 2012 at 2:57 PM, Jord Tanner < reply@reply.github.com

wrote:

You can merge this Pull Request by running:

git pull https://github.com/jordtanner/rightscale_cookbooks master

Or you can view, comment on it, or merge it online at:

https://github.com/rightscale/rightscale_cookbooks/pull/140

-- Commit Summary --

  • fix error in platform definition

-- File Changes --

M cookbooks/db_mysql/recipes/default_5_1.rb (4) M cookbooks/db_mysql/recipes/default_5_5.rb (6)

-- Patch Links --

https://github.com/rightscale/rightscale_cookbooks/pull/140.patch https://github.com/rightscale/rightscale_cookbooks/pull/140.diff


Reply to this email directly or view it on GitHub: https://github.com/rightscale/rightscale_cookbooks/pull/140

ryanoleary commented 12 years ago

Jord,

After examining this with our engineering team, we've actually already implemented this fix in our private repo (we do our dev primarily on a private repo and then periodically push all those changes to the public repo). So, while in this particular case this pull request won't be needed, we encourage you to continue to submit fixes/improvements after you've completed the Contributor Agreement.

Thanks again, and have a great weekend.

Ryan O'Leary Product Manager ryan.oleary@rightscale.com skype: ryan.oleary.rs phone: 805-243-0977

On Thu, Aug 2, 2012 at 4:15 PM, Ryan O'Leary ryan.oleary@rightscale.comwrote:

Hi Jord. Thanks for the pull request. In order for us to accept it, we need you to complete a Contributor Agreement. For details on the process, see here:

http://support.rightscale.com/12-Guides/Chef_Cookbooks_Developer_Guide/08-Chef_Development/03-Contribute_to_RightScale_Cookbooks

If you have any questions, let me know. Thanks.

Ryan O'Leary Product Manager ryan.oleary@rightscale.com skype: ryan.oleary.rs phone: 805-243-0977

On Thu, Aug 2, 2012 at 2:57 PM, Jord Tanner < reply@reply.github.com

wrote:

You can merge this Pull Request by running:

git pull https://github.com/jordtanner/rightscale_cookbooks master

Or you can view, comment on it, or merge it online at:

https://github.com/rightscale/rightscale_cookbooks/pull/140

-- Commit Summary --

  • fix error in platform definition

-- File Changes --

M cookbooks/db_mysql/recipes/default_5_1.rb (4) M cookbooks/db_mysql/recipes/default_5_5.rb (6)

-- Patch Links --

https://github.com/rightscale/rightscale_cookbooks/pull/140.patch https://github.com/rightscale/rightscale_cookbooks/pull/140.diff


Reply to this email directly or view it on GitHub: https://github.com/rightscale/rightscale_cookbooks/pull/140