flexera-public / rightscale_cookbooks

Other
76 stars 102 forks source link

collectd pinned version should be 4.10.1-2.1ubuntu7 on 12.04 #143

Closed gonzalez closed 11 years ago

gonzalez commented 12 years ago

chef attributes for 12 https://github.com/rightscale/rightscale_cookbooks/blob/master/cookbooks/rightscale/attributes/monitoring.rb

when /^12..+/ set_unless[:rightscale][:collectd_packages_version] = "latest" else set_unless[:rightscale][:collectd_packages_version] = "4.10.1-2"

should be

when /^12..+/ set_unless[:rightscale][:collectd_packages_version] = "latest" else set_unless[:rightscale][:collectd_packages_version] = "4.10.1-2.1ubuntu7"

root@ip-10-68-22-119:~# apt-get install collectd=4.10.1-2 Reading package lists... Done Building dependency tree
Reading state information... Done E: Version '4.10.1-2' for 'collectd' was not found

[8/23/12 4:25:23 PM] Edwin: root@ip-10-68-22-119:~# apt-get install collectd=4.10.1-2.1ubuntu7 Reading package lists... Done Building dependency tree
Reading state information... Done Recommended packages: libesmtp6 libmemcached6 libnotify4 libopenipmi0 liboping0 libperl5.14 libpq5 libsnmp15 libtokyotyrant3 libupsclient1 libvirt0 libyajl1 The following NEW packages will be installed: collectd

Thanks.

lopaka commented 11 years ago

The current logic in place is to pin collectd version to 'latest' if ubuntu 12.. This code change will do nothing if OS is ubuntu 12..

Since we only develop on Ubuntu 12, there is no reason to use this code. As a result, this pull request will be closed. If there are concerns that using this code for ubuntu 12 is needed, please let me know.

Thanks, Lopaka