flexera-public / rightscale_cookbooks

Other
76 stars 102 forks source link

CONTRIB: Apply the environment on the first chef-client run; otherwise, the envir... #150

Closed nabeelio closed 11 years ago

nabeelio commented 11 years ago

Use the -E [environment] on the first run of the chef-client, otherwise, the environment is not applied to the node, and the provisioning can fail, depending on what the settings for the environment are.

lopaka commented 11 years ago

Hello Nabeel,

We appreciate your contribution to the RightScale cookbooks. Before we can proceed with the process of reviewing and merging your pull request, please follow step one on our Contribute to RightScale Cookbooks site and sign the RightScale Contributors Agreement.

Thank you.

nabeelio commented 11 years ago

No problem, done

lopaka commented 11 years ago

Made comment about the -E flag not needed on line 74.

As a result, I will be closing this pull request. Please comment and reopen if you feel this should still be addressed.

Thanks, Lopaka

lopaka commented 11 years ago

Reopened to investigate claims of chef-environment not applied at first start.

autrejacoupa commented 11 years ago

We need -E option. Cannot get RS "Chef Client Beta (v13.3)" template to work with chef environment.

lopaka commented 11 years ago

Currently being worked on.

lopaka commented 11 years ago

Commits have been cherry picked to our development repository and worked on to follow our coding standards and logic. As a result, this code review will be closed. Once we push the code to public, you will be able to view your commit. Thanks for your contribution.