search

flexera-public / rightscale_cookbooks

Other
76 stars 102 forks source link

Sprint12 04 a45635 rightscale cookbook manual review #56

Closed mrusan closed 12 years ago

ekargard commented 12 years ago

Other than needed to revert the changes to the collectd packages /etc/init script it looks great!

Okay to merge after resetting collectd-init-centos-with-monitor

Erik

On Fri, Jun 1, 2012 at 9:46 AM, Maksim Rusan < reply@reply.github.com

wrote:

You can merge this Pull Request by running:

git pull https://github.com/rightscale/rightscale_cookbookssprint12_04_a45635_rightscale_cookbook_manual_review

Or you can view, comment on it, or merge it online at:

https://github.com/rightscale/rightscale_cookbooks/pull/56

-- Commit Summary --

  • [rightscale] Initial commit
  • [rightscale] Indentation and white space trailing fix
  • [rightscale] attributes file comment alteration
  • [rightscale] definitions code alteration
  • [rightscale] removed tabs in collectd init file
  • [rightscale] indent and comment fix to file-stats.rb
  • [rightscale] changed helper.rb comments to comply with yard
  • [rightscale] description for the provider
  • [rightscale] code iterations for the recipes
  • [rightscale] comments to resource
  • [rightscale] removed tabs in template
  • [rightscale] metadata update

-- File Changes --

M cookbooks/rightscale/attributes/default.rb (39) M cookbooks/rightscale/definitions/rightscale_enable_collectd_plugin.rb (2) M cookbooks/rightscale/definitions/rightscale_logrotate_app.rb (1) M cookbooks/rightscale/definitions/rightscale_marker.rb (5) M cookbooks/rightscale/definitions/rightscale_monitor_process.rb (2) M cookbooks/rightscale/files/default/collectd-init-centos-with-monitor (54) M cookbooks/rightscale/files/default/file-stats.rb (20) M cookbooks/rightscale/libraries/helper.rb (53) M cookbooks/rightscale/metadata.json (222) M cookbooks/rightscale/metadata.rb (171) M cookbooks/rightscale/providers/server_collection.rb (4) M cookbooks/rightscale/recipes/default.rb (11) M cookbooks/rightscale/recipes/install_file_stats_collectd_plugin.rb (2) M cookbooks/rightscale/recipes/install_mysql_collectd_plugin.rb (5) M cookbooks/rightscale/recipes/setup_hostname.rb (90) M cookbooks/rightscale/recipes/setup_mail.rb (16) M cookbooks/rightscale/recipes/setup_monitoring.rb (30) M cookbooks/rightscale/recipes/setup_server_tags.rb (4) M cookbooks/rightscale/recipes/setup_ssh.rb (16) M cookbooks/rightscale/recipes/setup_timezone.rb (7) M cookbooks/rightscale/resources/server_collection.rb (7) M cookbooks/rightscale/templates/default/hosts.erb (4)

-- Patch Links --

https://github.com/rightscale/rightscale_cookbooks/pull/56.patch https://github.com/rightscale/rightscale_cookbooks/pull/56.diff

Reply to this email directly or view it on GitHub: https://github.com/rightscale/rightscale_cookbooks/pull/56