search

flexera-public / rightscale_cookbooks

Other
76 stars 103 forks source link

Release 12 h1 logging change for port #77

Closed evanwieren closed 12 years ago

evanwieren commented 12 years ago

Allow customer to specify not only the server, but the port for syslog.

caryp commented 12 years ago

Here are our contributor guidelines and link to the agreement...

== CONTRIBUTING:

Contributors to the RightScale cookbooks need to agree to and sign the {RightScale Contributors Agreement}[https://rightscale.echosign.com/public/hostedForm?formid=3SMKS95X3F5G3S] before contributions will be accepted.

To contribute changes back to the RightScale cookbooks:

  1. Fork the repository on GitHub.
  2. Make changes on a branch in your forked repository.
  3. Rebase from the master branch.
  4. Make a pull request.

On Tue, Jun 12, 2012 at 12:02 PM, evanwieren < reply@reply.github.com

wrote:

Allow customer to specify not only the server, but the port for syslog.

You can merge this Pull Request by running:

git pull https://github.com/evanwieren/rightscale_cookbooks release_12H1

Or you can view, comment on it, or merge it online at:

https://github.com/rightscale/rightscale_cookbooks/pull/77

-- Commit Summary --

  • Adding new attribute server_port
  • Adding remote_port rsyslog provider
  • Added remote_port to syslog-ng logging.
  • Updated erb to support alternate syslog port
  • Added default server_port to 514
  • Added call to specific logging func for std cmds.
  • Updating metadata
  • Missed a comma in logging providers file.
  • Missing some variable defs and inputs.
  • Switching 514 to variable.
  • Updated shown Recipes
  • Missing a comma.

-- File Changes --

M cookbooks/logging/attributes/default.rb (3) M cookbooks/logging/metadata.json (78) M cookbooks/logging/metadata.rb (8) M cookbooks/logging/recipes/default.rb (7) M cookbooks/logging/recipes/do_server_restart.rb (6) M cookbooks/logging/recipes/do_server_start.rb (7) M cookbooks/logging/recipes/do_server_stop.rb (6) M cookbooks/logging/resources/default.rb (1) M cookbooks/logging_rsyslog/metadata.json (35) M cookbooks/logging_rsyslog/metadata.rb (3) M cookbooks/logging_rsyslog/providers/default.rb (6) M cookbooks/logging_rsyslog/templates/default/rsyslog.d.remote.conf.erb (2) M cookbooks/logging_syslog_ng/metadata.json (35) M cookbooks/logging_syslog_ng/metadata.rb (3) M cookbooks/logging_syslog_ng/providers/default.rb (4) M cookbooks/logging_syslog_ng/templates/default/syslog-ng.conf.remote.erb (2)

-- Patch Links --

https://github.com/rightscale/rightscale_cookbooks/pull/77.patch https://github.com/rightscale/rightscale_cookbooks/pull/77.diff

Reply to this email directly or view it on GitHub: https://github.com/rightscale/rightscale_cookbooks/pull/77

Cary Penniman Sr. Software Developer www.RightScale.com http://www.rightscale.com/

Phone: (805) 243-0222 Email: cary@rightscale.com Skype: carypenniman

Talk with the Experts Register today for the RightScale Conference! June 13, 2012 in New York, NY http://www.rightscale.com/conference

caryp commented 12 years ago

Looks great, Eric. I found a couple issues and a couple nit-picks. Also, the guys say it is too late to make the cut for this release -- my bad. Can you please close this pull request and make it again against the master branch?

Thanks again for the contribution!

-Cary P

On Tue, Jun 12, 2012 at 12:02 PM, evanwieren < reply@reply.github.com

wrote:

Allow customer to specify not only the server, but the port for syslog.

You can merge this Pull Request by running:

git pull https://github.com/evanwieren/rightscale_cookbooks release_12H1

Or you can view, comment on it, or merge it online at:

https://github.com/rightscale/rightscale_cookbooks/pull/77

-- Commit Summary --

  • Adding new attribute server_port
  • Adding remote_port rsyslog provider
  • Added remote_port to syslog-ng logging.
  • Updated erb to support alternate syslog port
  • Added default server_port to 514
  • Added call to specific logging func for std cmds.
  • Updating metadata
  • Missed a comma in logging providers file.
  • Missing some variable defs and inputs.
  • Switching 514 to variable.
  • Updated shown Recipes
  • Missing a comma.

-- File Changes --

M cookbooks/logging/attributes/default.rb (3) M cookbooks/logging/metadata.json (78) M cookbooks/logging/metadata.rb (8) M cookbooks/logging/recipes/default.rb (7) M cookbooks/logging/recipes/do_server_restart.rb (6) M cookbooks/logging/recipes/do_server_start.rb (7) M cookbooks/logging/recipes/do_server_stop.rb (6) M cookbooks/logging/resources/default.rb (1) M cookbooks/logging_rsyslog/metadata.json (35) M cookbooks/logging_rsyslog/metadata.rb (3) M cookbooks/logging_rsyslog/providers/default.rb (6) M cookbooks/logging_rsyslog/templates/default/rsyslog.d.remote.conf.erb (2) M cookbooks/logging_syslog_ng/metadata.json (35) M cookbooks/logging_syslog_ng/metadata.rb (3) M cookbooks/logging_syslog_ng/providers/default.rb (4) M cookbooks/logging_syslog_ng/templates/default/syslog-ng.conf.remote.erb (2)

-- Patch Links --

https://github.com/rightscale/rightscale_cookbooks/pull/77.patch https://github.com/rightscale/rightscale_cookbooks/pull/77.diff

Reply to this email directly or view it on GitHub: https://github.com/rightscale/rightscale_cookbooks/pull/77

Cary Penniman Sr. Software Developer www.RightScale.com http://www.rightscale.com/

Phone: (805) 243-0222 Email: cary@rightscale.com Skype: carypenniman

Talk with the Experts Register today for the RightScale Conference! June 13, 2012 in New York, NY http://www.rightscale.com/conference

evanwieren commented 12 years ago

I will add a few tweaks and do a pull request against master. Or should I wait till your branch merges with master?

caryp commented 12 years ago

The sooner the better. I am hoping the guys will pull this into the release anyways, but we'll see.

-CP

On Jun 13, 2012, at 7:59 AM, evanwierenreply@reply.github.com wrote:

I will add a few tweaks and do a pull request against master. Or should I wait till your branch merges with master?

Reply to this email directly or view it on GitHub: https://github.com/rightscale/rightscale_cookbooks/pull/77#issuecomment-6298992

evanwieren commented 12 years ago

I have already pulled my pull request, but the amount of work was trivial.

I should be able do more now that I understand the layout of the chef stuff.

Thanks for the brief tour.

Eric

On Wed, Jun 13, 2012 at 8:13 AM, caryp < reply@reply.github.com

wrote:

The sooner the better. I am hoping the guys will pull this into the release anyways, but we'll see.

-CP

On Jun 13, 2012, at 7:59 AM, evanwierenreply@reply.github.com wrote:

I will add a few tweaks and do a pull request against master. Or should I wait till your branch merges with master?

Reply to this email directly or view it on GitHub:

https://github.com/rightscale/rightscale_cookbooks/pull/77#issuecomment-6298992

Reply to this email directly or view it on GitHub:

https://github.com/rightscale/rightscale_cookbooks/pull/77#issuecomment-6299247