Add more inheritance for graphs

flexflow / FlexFlow

FlexFlow Serve: Low-Latency, High-Performance LLM Serving

https://flexflow.readthedocs.io

Apache License 2.0

1.6k stars 219 forks source link

Open wmdi opened 5 months ago

wmdi commented 5 months ago

Currently, the inheritance tree of graphs is:

IXGraphView inherits from IYGraphView according to their functionality;
XGraphView inherits from YGraphView if IXGraphView inherits from IYGraphView;
IXGraph inherits from IXGraphView;
XGraph inherits from XGraphView.

Add more inheritance among IXGraphs and among XGraphs to reuse some of the interfaces.

wmdi commented 5 months ago

Comments in #1189 could help

lockshaw commented 5 months ago

Can you clarify what the additional inheritance would look like? Is this for the graphs themselves or for the edge/node structures?