Improve `get_subgraph` for open graphs

flexflow / FlexFlow

FlexFlow Serve: Low-Latency, High-Performance LLM Serving

https://flexflow.readthedocs.io

Apache License 2.0

1.67k stars 224 forks source link

Improve `get_subgraph` for open graphs #1284

Open wmdi opened 8 months ago

wmdi commented 8 months ago

Currently get_subgraph for open graphs involves a template parameter to specify the open type of the subgraph (closed, upward open, downward open, or open). Change the design so that get_subgraph for open graphs always gives a fully open subgraph (for other types, we should call an additional conversion between different types of open graphs).

lockshaw commented 6 months ago

@wmdi According to https://reviewable.io/reviews/flexflow/FlexFlow/1229#-NpXFiYg5H4L6MjeIFUV it seems that this issue tracks more than just get_subgraph--can you add additional detail to this issue or create an additional issue for the improvement mentioned there?