Open wmdi opened 4 months ago
@wmdi When you divide up this issue can you make sure to make individual issues for (1) separating up the DP, and (2) separating up the MCMC search? I'm guessing it'll be easier to handle them individually rather than solving both at once
@wmdi Can you also make sure the rapidcheck issues you ran into get a corresponding issue created?
@wmdi Can you make sure that a more detailed issue gets created for https://reviewable.io/reviews/flexflow/FlexFlow/1229#-NpXEwmgBs4Q6-g0dSIh? This issue doesn't really mention it currently
@wmdi Can you make sure https://reviewable.io/reviews/flexflow/FlexFlow/1229#-NpXFKHVCMVgHr2GOPAK gets linked to in whatever issue(s) get created for graph hashing?
@wmdi Can you make sure that https://reviewable.io/reviews/flexflow/FlexFlow/1229#-NpXIiYi1DIya7jad3kQ gets linked in the issue that you create for handling variants in the graph library?
This issue is to track the remaining TODOs to improve the design of
compiler
.Strategy
. It seems unreasonable to putruntime
as part ofStrategy
since it is determined bypcg
andmachine_mapping
. Also, whether to usevisitable
forStrategy
should be considered.estimate_cost
. The current version does not take parallelization into account.ParallelComputationGraph
.