search

flexflow / FlexFlow

FlexFlow Serve: Low-Latency, High-Performance LLM Serving
https://flexflow.readthedocs.io
Apache License 2.0
1.67k stars 224 forks source link

`inputs` not initialized in `UpwardOpenMultiDiSubgraphView` #1334

Open lockshaw opened 6 months ago

lockshaw commented 6 months ago

An uninitialized value of inputs is being used in the code below:

UpwardOpenMultiDiSubgraphView::UpwardOpenMultiDiSubgraphView(
    OpenMultiDiGraphView const &g, std::unordered_set<Node> const &nodes)
    : g(g), nodes(nodes), inputs(inputs) {}

https://github.com/flexflow/FlexFlow/blob/addba97705bc4189aca3b2d0a949eb240357338e/lib/utils/src/graph/views.cc#L470-L472

lockshaw commented 6 months ago

@Marsella8 This seems likely to be a pretty easy fix and maybe a good way to get acquainted with the graph code. If this turns out not to be the case, let me know and @wmdi or I can help out :slightly_smiling_face: