Hip Refactor - Githubissues

flexflow / FlexFlow

FlexFlow Serve: Low-Latency, High-Performance LLM Serving

https://flexflow.readthedocs.io

Apache License 2.0

1.59k stars 218 forks source link

Hip Refactor #1359

Closed Bob-Chen222 closed 1 month ago

Bob-Chen222 commented 3 months ago

Description of changes: Hi @lockshaw Colin and @reyna-abhyankar Reyna, This PR aligned the hip of linear and layer_norm against the Cuda version. If everything works fine, I can proceed to change other hip kernels.

Related Issues:

Linked Issues:

Issue #1296

Issues closed by this PR:

Closes #1296

This change is

Bob-Chen222 commented 2 months ago

Hi @reyna-abhyankar, I believe that everything is fixed now! Redundant changes from substitution are eliminated and all the requests you made have been fixed.