flexflow / FlexFlow

FlexFlow Serve: Low-Latency, High-Performance LLM Serving
https://flexflow.readthedocs.io
Apache License 2.0
1.59k stars 218 forks source link

Kernel build #1366

Closed reyna-abhyankar closed 2 months ago

reyna-abhyankar commented 2 months ago

Description of changes:

Build all operator .cu files in lib/kernels

Note: there is an issue with embedding.cu with the half datatype. All other operators are building.


This change is Reviewable

lockshaw commented 2 months ago

@reyna-abhyankar Can you add the cuda part of kernels to CI as part of this PR? Otherwise it'll just break immediately

lockshaw commented 2 months ago

lib/op-attrs/include/op-attrs/activation.h line 8 at r1 (raw file):

namespace FlexFlow {

enum class Activation { RELU, SIGMOID, TANH, GELU, NONE };

Why not just use std::optional<Activation> where you need this behavior?

lockshaw commented 2 months ago

@reyna-abhyankar Ignore the above, it was already added.