search

flexflow / FlexFlow

FlexFlow Serve: Low-Latency, High-Performance LLM Serving
https://flexflow.readthedocs.io
Apache License 2.0
1.67k stars 223 forks source link

Optional CodeCoverage Building Instrumentation #1390

Closed Bob-Chen222 closed 4 months ago

Bob-Chen222 commented 4 months ago

Need to figure out a way to build the FlexFlow with code coverage instrumentation optionally.

Bob-Chen222 commented 4 months ago

The easiest thing I can come up with now is that when the user calls proj make, two different build directories will come out. One is with instrumentation, and one is not. When the user calls proj test --coverage, it will run in the directory with coverage instrumentation. Otherwise, it will run in the original build repo. Do you think this would work? @lockshaw

lockshaw commented 4 months ago

I would recommend only building the with-instrumentation version when the user runs tests with coverage, as most of the time the user will not be examining the coverage information and we don't want to unnecessarily slow down most builds. Note that proj test already builds things that proj build does not (proj build does not build the test suites), so this isn't anything particularly new

lockshaw commented 4 months ago

Closed by #1396