search

flexflow / FlexFlow

FlexFlow Serve: Low-Latency, High-Performance LLM Serving
https://flexflow.readthedocs.io
Apache License 2.0
1.67k stars 223 forks source link

filtering out dtgen related files in code coverage report #1406

Closed Bob-Chen222 closed 3 months ago

Bob-Chen222 commented 4 months ago

Description of changes:

filtering out dtgen related files in code coverage report in ci. Previously the problem is that gcov in codecov/action will be run again as plugin and all the .gcov files will be generated and included into the final report. I disabled gcov by specify the pycoverage to be used as plugin, which temporarily solved the problem. Since we are going to move ci to proj I think this solution is good enough for now. I will investigate further in the background

Related Issues:

Linked Issues:

Issues closed by this PR:

This change is Reviewable

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 38.10%. Comparing base (f93e262) to head (4103cc8).

:exclamation: Current head 4103cc8 differs from pull request most recent head ec02c14

Please upload reports for the commit ec02c14 to get more accurate results.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## repo-refactor #1406 +/- ## ================================================== + Coverage 18.81% 38.10% +19.28% ================================================== Files 263 167 -96 Lines 12631 5026 -7605 Branches 0 246 +246 ================================================== - Hits 2377 1915 -462 + Misses 10254 3111 -7143 ``` | [Flag](https://app.codecov.io/gh/flexflow/FlexFlow/pull/1406/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flexflow) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/flexflow/FlexFlow/pull/1406/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flexflow) | `38.10% <ø> (+19.28%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flexflow#carryforward-flags-in-the-pull-request-comment) to find out more. [see 116 files with indirect coverage changes](https://app.codecov.io/gh/flexflow/FlexFlow/pull/1406/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flexflow)