search

flexflow / FlexFlow

FlexFlow Serve: Low-Latency, High-Performance LLM Serving
https://flexflow.readthedocs.io
Apache License 2.0
1.59k stars 218 forks source link

Local execution tests #1418

Open reyna-abhyankar opened 2 weeks ago

reyna-abhyankar commented 2 weeks ago

Description of changes:

Tests for local backing workflow

Related Issues:

Linked Issues:

Issues closed by this PR:

This change is Reviewable

lockshaw commented 1 week ago

lib/local-execution/test/src/test_local_backing_multi.cc line 117 at r1 (raw file):

    std::vector<layer_guid_t> layer_guids =
        topological_ordering(cg_builder.computation_graph);
    layer_guid_t cast_layer_guid = layer_guids.at(0);

A better way is to probably add the ability to get a layer by name in ComputationGraph

codecov[bot] commented 2 days ago

Codecov Report

Attention: Patch coverage is 0% with 385 lines in your changes missing coverage. Please review.

Project coverage is 38.02%. Comparing base (7bd12e3) to head (987b9ce).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## repo-refactor #1418 +/- ## ================================================= - Coverage 39.28% 38.02% -1.26% ================================================= Files 253 261 +8 Lines 8859 9151 +292 Branches 324 346 +22 ================================================= Hits 3480 3480 - Misses 5379 5671 +292 ``` | [Flag](https://app.codecov.io/gh/flexflow/FlexFlow/pull/1418/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flexflow) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/flexflow/FlexFlow/pull/1418/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flexflow) | `38.02% <0.00%> (-1.26%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flexflow#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/flexflow/FlexFlow/pull/1418?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flexflow) | Coverage Δ | | |---|---|---| | [lib/kernels/include/kernels/accessor.h](https://app.codecov.io/gh/flexflow/FlexFlow/pull/1418?src=pr&el=tree&filepath=lib%2Fkernels%2Finclude%2Fkernels%2Faccessor.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flexflow#diff-bGliL2tlcm5lbHMvaW5jbHVkZS9rZXJuZWxzL2FjY2Vzc29yLmg=) | `0.00% <ø> (ø)` | | | [lib/kernels/include/kernels/array\_shape.h](https://app.codecov.io/gh/flexflow/FlexFlow/pull/1418?src=pr&el=tree&filepath=lib%2Fkernels%2Finclude%2Fkernels%2Farray_shape.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flexflow#diff-bGliL2tlcm5lbHMvaW5jbHVkZS9rZXJuZWxzL2FycmF5X3NoYXBlLmg=) | `0.00% <ø> (ø)` | | | [lib/kernels/include/kernels/attention\_kernels.h](https://app.codecov.io/gh/flexflow/FlexFlow/pull/1418?src=pr&el=tree&filepath=lib%2Fkernels%2Finclude%2Fkernels%2Fattention_kernels.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flexflow#diff-bGliL2tlcm5lbHMvaW5jbHVkZS9rZXJuZWxzL2F0dGVudGlvbl9rZXJuZWxzLmg=) | `0.00% <ø> (ø)` | | | [lib/kernels/include/kernels/transpose\_kernels.h](https://app.codecov.io/gh/flexflow/FlexFlow/pull/1418?src=pr&el=tree&filepath=lib%2Fkernels%2Finclude%2Fkernels%2Ftranspose_kernels.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flexflow#diff-bGliL2tlcm5lbHMvaW5jbHVkZS9rZXJuZWxzL3RyYW5zcG9zZV9rZXJuZWxzLmg=) | `0.00% <ø> (ø)` | | | [...ude/local-execution/local\_task\_argument\_accessor.h](https://app.codecov.io/gh/flexflow/FlexFlow/pull/1418?src=pr&el=tree&filepath=lib%2Flocal-execution%2Finclude%2Flocal-execution%2Flocal_task_argument_accessor.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flexflow#diff-bGliL2xvY2FsLWV4ZWN1dGlvbi9pbmNsdWRlL2xvY2FsLWV4ZWN1dGlvbi9sb2NhbF90YXNrX2FyZ3VtZW50X2FjY2Vzc29yLmg=) | `0.00% <ø> (ø)` | | | [...n/include/local-execution/local\_training\_backing.h](https://app.codecov.io/gh/flexflow/FlexFlow/pull/1418?src=pr&el=tree&filepath=lib%2Flocal-execution%2Finclude%2Flocal-execution%2Flocal_training_backing.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flexflow#diff-bGliL2xvY2FsLWV4ZWN1dGlvbi9pbmNsdWRlL2xvY2FsLWV4ZWN1dGlvbi9sb2NhbF90cmFpbmluZ19iYWNraW5nLmg=) | `0.00% <ø> (ø)` | | | [...ution/include/local-execution/op\_task\_invocation.h](https://app.codecov.io/gh/flexflow/FlexFlow/pull/1418?src=pr&el=tree&filepath=lib%2Flocal-execution%2Finclude%2Flocal-execution%2Fop_task_invocation.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flexflow#diff-bGliL2xvY2FsLWV4ZWN1dGlvbi9pbmNsdWRlL2xvY2FsLWV4ZWN1dGlvbi9vcF90YXNrX2ludm9jYXRpb24uaA==) | `0.00% <ø> (ø)` | | | [...cution/include/local-execution/op\_task\_signature.h](https://app.codecov.io/gh/flexflow/FlexFlow/pull/1418?src=pr&el=tree&filepath=lib%2Flocal-execution%2Finclude%2Flocal-execution%2Fop_task_signature.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flexflow#diff-bGliL2xvY2FsLWV4ZWN1dGlvbi9pbmNsdWRlL2xvY2FsLWV4ZWN1dGlvbi9vcF90YXNrX3NpZ25hdHVyZS5o) | `0.00% <ø> (ø)` | | | [...-execution/include/local-execution/task\_registry.h](https://app.codecov.io/gh/flexflow/FlexFlow/pull/1418?src=pr&el=tree&filepath=lib%2Flocal-execution%2Finclude%2Flocal-execution%2Ftask_registry.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flexflow#diff-bGliL2xvY2FsLWV4ZWN1dGlvbi9pbmNsdWRlL2xvY2FsLWV4ZWN1dGlvbi90YXNrX3JlZ2lzdHJ5Lmg=) | `0.00% <ø> (ø)` | | | [...cution/include/local-execution/tracked\_allocator.h](https://app.codecov.io/gh/flexflow/FlexFlow/pull/1418?src=pr&el=tree&filepath=lib%2Flocal-execution%2Finclude%2Flocal-execution%2Ftracked_allocator.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flexflow#diff-bGliL2xvY2FsLWV4ZWN1dGlvbi9pbmNsdWRlL2xvY2FsLWV4ZWN1dGlvbi90cmFja2VkX2FsbG9jYXRvci5o) | `0.00% <ø> (ø)` | | | ... and [37 more](https://app.codecov.io/gh/flexflow/FlexFlow/pull/1418?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flexflow) | | ... and [4 files with indirect coverage changes](https://app.codecov.io/gh/flexflow/FlexFlow/pull/1418/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flexflow)