flexflow / FlexFlow

FlexFlow Serve: Low-Latency, High-Performance LLM Serving
https://flexflow.readthedocs.io
Apache License 2.0
1.67k stars 223 forks source link

Implementations for methods for machine_views and associated modules #1429

Closed Marsella8 closed 2 months ago

Marsella8 commented 3 months ago

Description of changes:

Implemented NOT_IMPLEMENTED() functions within machine_view.cc, strided_rectangle.cc, strided_rectangle_sides.cc, device_id.cc.

Related Issues:

Linked Issues:

Issues closed by this PR:


This change is Reviewable

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 40.05%. Comparing base (d30c8f0) to head (61ae1c6). Report is 6 commits behind head on repo-refactor.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## repo-refactor #1429 +/- ## ================================================= + Coverage 38.78% 40.05% +1.26% ================================================= Files 256 258 +2 Lines 8973 9096 +123 Branches 331 334 +3 ================================================= + Hits 3480 3643 +163 + Misses 5493 5453 -40 ``` | [Flag](https://app.codecov.io/gh/flexflow/FlexFlow/pull/1429/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flexflow) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/flexflow/FlexFlow/pull/1429/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flexflow) | `40.05% <100.00%> (+1.26%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flexflow#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/flexflow/FlexFlow/pull/1429?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flexflow) | Coverage Δ | | |---|---|---| | [lib/pcg/src/pcg/machine\_view.cc](https://app.codecov.io/gh/flexflow/FlexFlow/pull/1429?src=pr&el=tree&filepath=lib%2Fpcg%2Fsrc%2Fpcg%2Fmachine_view.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flexflow#diff-bGliL3BjZy9zcmMvcGNnL21hY2hpbmVfdmlldy5jYw==) | `92.85% <100.00%> (+92.85%)` | :arrow_up: | | [lib/pcg/src/pcg/strided\_rectangle\_side.cc](https://app.codecov.io/gh/flexflow/FlexFlow/pull/1429?src=pr&el=tree&filepath=lib%2Fpcg%2Fsrc%2Fpcg%2Fstrided_rectangle_side.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flexflow#diff-bGliL3BjZy9zcmMvcGNnL3N0cmlkZWRfcmVjdGFuZ2xlX3NpZGUuY2M=) | `100.00% <100.00%> (+100.00%)` | :arrow_up: | | [lib/pcg/src/strided\_rectangle.cc](https://app.codecov.io/gh/flexflow/FlexFlow/pull/1429?src=pr&el=tree&filepath=lib%2Fpcg%2Fsrc%2Fstrided_rectangle.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flexflow#diff-bGliL3BjZy9zcmMvc3RyaWRlZF9yZWN0YW5nbGUuY2M=) | `100.00% <100.00%> (+100.00%)` | :arrow_up: | | [lib/pcg/test/src/test\_machine\_view.cc](https://app.codecov.io/gh/flexflow/FlexFlow/pull/1429?src=pr&el=tree&filepath=lib%2Fpcg%2Ftest%2Fsrc%2Ftest_machine_view.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flexflow#diff-bGliL3BjZy90ZXN0L3NyYy90ZXN0X21hY2hpbmVfdmlldy5jYw==) | `100.00% <100.00%> (ø)` | | | [lib/pcg/test/src/test\_strided\_rectangle.cc](https://app.codecov.io/gh/flexflow/FlexFlow/pull/1429?src=pr&el=tree&filepath=lib%2Fpcg%2Ftest%2Fsrc%2Ftest_strided_rectangle.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flexflow#diff-bGliL3BjZy90ZXN0L3NyYy90ZXN0X3N0cmlkZWRfcmVjdGFuZ2xlLmNj) | `100.00% <100.00%> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/flexflow/FlexFlow/pull/1429/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flexflow)