search

flexflow / FlexFlow

FlexFlow Serve: Low-Latency, High-Performance LLM Serving
https://flexflow.readthedocs.io
Apache License 2.0
1.7k stars 226 forks source link

Deadcode Elimination #306

Closed jiazhihao closed 1 year ago

jiazhihao commented 2 years ago

Hi issue tracks the progress of eliminating #ifdef DEADCODE ... #endif marcos in the codebase.

lockshaw commented 2 years ago

@virena You mind taking care of this? Should be pretty simple, just go through the code and remove any DEADCODE ifdefs. If any look important (i.e., things we should not be deleting for some reason) we can discuss them here.

No particular rush on this issue, just when you get time :slightly_smiling_face:

lockshaw commented 2 years ago

Also see https://github.com/flexflow/FlexFlow/blob/34a21dd7a3cf30100a9c4cb87318633495c001f9/python/flexflow_dataloader.cc#L782

eddy16112 commented 2 years ago

We have many data loader classes that are not used anymore, please see here https://github.com/flexflow/FlexFlow/blob/master/python/flexflow_dataloader.h#L34 On Python side, the following code can be removed https://github.com/flexflow/FlexFlow/blob/master/python/flexflow/core/flexflow_cffi.py#L2195-L2240