flexflow / FlexFlow

FlexFlow Serve: Low-Latency, High-Performance LLM Serving
https://flexflow.readthedocs.io
Apache License 2.0
1.67k stars 224 forks source link

Add unit tests for C++ helper code in `kernels` #948

Open lockshaw opened 1 year ago

lockshaw commented 1 year ago

There exist a number of definitions in kernels that aren't part of the kernels themselves, but are used in them. An (inexhaustive and potentially outdated) list of their header files are below:

The code in these files has not been updated in a while, and may not have been fully implemented. Update this code (for example, dtgen instead of visitable), make sure it's implemented, determine what makes sense to test, and write the corresponding unit tests

lockshaw commented 1 week ago

@oOTigger Do you mind taking this over? It's been partially implemented in #992, but as that was created a while ago it may need some updating, polishing, etc.