search

flexibeast / ebuku

Emacs interface to the buku Web bookmark manager.
92 stars 7 forks source link

ADDED new api interfaces for interacting with tags. #17

Open Plommonsorbet opened 4 years ago

Plommonsorbet commented 4 years ago

Hi,

I was migrating all of my bookmarks to buku and in the migration process I ended up wanting to tag a lot of bookmarks so I created a few api functions for this and since this functionality was not in the module I figured I would push it.

I'm new to emacs and lisp so I'm might have missed some coding conventions or general best practice so any feedback regarding it is appreciated.

Some notes regarding my code:

The ebuku--call-buku function seems to have the option to always write to the buffer enabled so I just wrapped my functions with the with-temp-buffer function to not have to do any bigger changes to the overall code to deal with instances where the output of the function doesn't matter.

Also I don't check for any errors in the process since buku doesn't seem to return any exit code other than 0 even when it outputs [ERROR]. I suppose I could try to regexp the output, but I couldn't seem to wrap my head around how the elisp dialect of regex works so I figured I would just leave it as it is for now and get your feedback on it or return to this later with fresh eyes.

flexibeast commented 4 years ago

Thanks for your contribution! Overall i like this. :-)

To begin with, i'll leave specific comments on the code as review notes.

Plommonsorbet commented 4 years ago

Hey,

I just wanted to say THANK YOU for taking the time to give me such great feedback! I really appreciate it, especially with naming and documentation conventions. I greatly value clean and uniform code/documentation so I'm trying to learn the generally accepted code and documentation style for elisp so your comments were really helpful!

Plommonsorbet commented 4 years ago

Heya,

Yeah it's a pretty crazy time so no worries about not getting back right away.

Thanks for the input, I'll get to this in a month. I just have one work week before going on vacation for three weeks and I can definitely feel myself beeing really worn down. So I'm just going to listen to my body right now.