flexibeast / ebuku

Emacs interface to the buku Web bookmark manager.
92 stars 7 forks source link

Replace 'map-put' with '(setf (map-elt ...) ...)'. #26

Closed rakino closed 1 year ago

rakino commented 1 year ago

This eliminates the following warning: ‘map-put’ is an obsolete macro (as of 27.1); use ‘map-put!’ or ‘(setf (map-elt ...) ...)’ instead.

flexibeast commented 1 year ago

Thanks for your contribution!

My intention at this point, as noted on the Package-Requires line near the beginning of the file, is to support versions of Emacs back to 25.1. Can you confirm that the (setf (map-elt ...) approach works that far back?

rakino commented 1 year ago

Unfortunately it doesn't... let*: Symbol’s function definition is void: \(setf\ map-elt\)

flexibeast commented 1 year ago

That error message doesn't look right to me; can you please show me the full line of code which causes that error?

rakino commented 1 year ago

It turns out adding (require 'map) solves the issue.

rakino commented 1 year ago

2022-11-21T22:21:02,651479749+08:00

flexibeast commented 1 year ago

Great - merged, thanks!