Open xinyazhang opened 3 years ago
Thanks for this fix. A few requests:
* Please describe the problem this fixes. What happens if reference_p is uninitialized? * The problem exists in FCL because of the lack of unit tests in the original implementation. We have been following a policy of adding missing tests as we improve the code. Please add a unit test that would have failed with reference_p uninitialized and now succeeds because of your fix. That will prevent future programmers from breaking this code ever again.
Reviewed 1 of 1 files at r1. Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @xinyazhang)
Got it, will add unit tests later.
The coefficients of Eigen::Vector3d, like other data types in Eigen3, are uninitialized by default.
This can be verified with the following code
This change is