search

flexible-collision-library / fcl

Flexible Collision Library
https://flexible-collision-library.github.io/
Other
1.39k stars 417 forks source link

Replace non-portable M_PI with constants::pi() #553

Open traversaro opened 2 years ago

traversaro commented 2 years ago

Similar to:

Problem originally experienced in https://github.com/conda-forge/fcl-feedstock/pull/11, but it seems it was also experienced in https://github.com/flexible-collision-library/fcl/issues/546 .

This change is Reviewable

traversaro commented 2 years ago

I am not sure why the problem was not detected in CI, I guess https://github.com/flexible-collision-library/fcl/issues/389 or something similar issue like https://github.com/flexible-collision-library/fcl/issues/442 . If there is interest in the fcl mantainers I would be happy to contribute and mantain a GitHub Actions-based CI script, either using conda-forge or vcpkg dependencies.

sherm1 commented 2 years ago

@traversaro I see CI is not triggering for this and other PRs. Any thoughts on how to fix?

traversaro commented 2 years ago

@traversaro I see CI is not triggering for this and other PRs. Any thoughts on how to fix?

I am not sure. Perhaps it is the mitigation against mining for which mantainers need to manually allow CI jobs from PRs?