search

flexible-collision-library / fcl

Flexible Collision Library
https://flexible-collision-library.github.io/
Other
1.35k stars 414 forks source link

Fix errors in sphereSphere and sphereTriangle intersect calculation #569

Closed shshlei closed 1 year ago

shshlei commented 2 years ago

This change is Reviewable

shshlei commented 2 years ago

For intersect detection, the penetration depth is calculated as a positive value.

SeanCurtis-TRI commented 1 year ago

@shshlei

FTR This PR seems like it's no longer the original PR. It appears you've been pushing commits to your master and every time you push it back to your remote repo, this PR is growing in scope and scale.

The original comments were never resolved. Unless I hear from the author in the next few days, I'm going to go ahead and close the PR.

SeanCurtis-TRI commented 1 year ago

The original PR was never finalized and now it has become polluted with subsequent, unrelated changes. If you want to pursue the original intent, please open another PR.