flexible-collision-library / fcl

Flexible Collision Library
https://flexible-collision-library.github.io/
Other
1.35k stars 415 forks source link

Limit the circumstances in which CI is kicked off #600

Closed SeanCurtis-TRI closed 1 year ago

SeanCurtis-TRI commented 1 year ago

With the previous spelling, if a forked version of FCL had actions enabled, then every push to every branch would kick off a mac/ubuntu CI event. This is ridiculous and telling forkers to not allow github actions is not the solution.

So, we take two strategies to spare the FCL contributors:

  1. We limit the CI to operate only on the master branch.
  2. The CI tasks become no-ops unless it is run on the FCL repo. This will still cause actions to be triggered, but they will silently do nothing in zero time.

This change is Reviewable

SeanCurtis-TRI commented 1 year ago

Testing strategy:

First confirm initial conditions -- there is actually a problem to be fixed:

Things to test (and how they're tested):

  1. No CI gets kicked off for an arbitrary branch on the fork.
    • [x] Looking at this fork's action history shows no entry for the branch underlying this PR (PR_limit_ci).
  2. No CI gets kicked off when I PR against a non-master branch on the fork.
  3. PR'ing against a fork's master triggers a CI, but it's a no-op.
  4. However, PRs against fcl/master still get tested.
SeanCurtis-TRI commented 1 year ago

I'm simply going to merge this as it shouldn't have touched appveyor at all.