search

flexiblepower / s2-ws-json

A WebSockets and JSON based protocol specification implementing the EN50491-12-2 "S2" standard for home and building energy management
Apache License 2.0
26 stars 2 forks source link

Inconsistens casing of "id" #15

Open tdittr opened 4 months ago

tdittr commented 4 months ago

Hi,

thanks for providing this specification openly. I am looking into demand response protocols and scrolled through your schemas, looks great so far!

I found a tiny typo and just thought I let you know. In DDBC.OperationMode.schema.json Line 6 id is written as Id. So far everywhere else I saw everything be snake case.

Nothing really significant but I thought I let you know while its still in beta.

wcoenraads commented 4 months ago

Ah, well noticed! Looking at my draft copy of the official spec, I see it also has Id with a capital I for DDBC.OperationMode specifically. I'll check if this is also the case in the definitive version of the spec. If that's the case, the schema is correct despite it being an unfortunate inconsistency. And otherwise I'll fix it this week :smile: