search

flexiblepower / s2-ws-json

A WebSockets and JSON based protocol specification implementing the EN50491-12-2 "S2" standard for home and building energy management
Apache License 2.0
26 stars 2 forks source link

FRBC.ActuatorDescription and FRBC.StorageDescription missing "status" field #8

Closed tonsmets closed 1 year ago

tonsmets commented 1 year ago

I just noticed the FRBC.ActuatorDescription and FRBC.StorageDescription schemas both are missing the "status" field. Could it be that the generator missed these while converting the S2 specification to json schemas?

wilcowijbrandi commented 1 year ago

Hi Ton,

We've decided to remove them from the description messages and put them in their own messages for s2-ws-json (FRBC.StorageStatus and FRBC.ActuatorStatus). This because they are much more dynamic than the 'Description' messages.

Cheers, Wilco

tonsmets commented 1 year ago

Thank you Wilco! So communicating the StorageStatus and ActuatorStatus should be done apart from the SystemDescription? I can see why you did this indeed as they are very dynamic and will change often. We just need to document this decision.