flexion / ef-cms

An Electronic Filing / Case Management System.
23 stars 10 forks source link

Fix List Item Accessibility Violation #10397

Open pixiwyn opened 3 months ago

pixiwyn commented 3 months ago

As a user of DAWSON, so that I can navigate the application using a screen reader and other accessibility tools, I need the paginator used in DAWSON to be free of accessibility violations.

Pre-Conditions

Acceptance Criteria

Notes

Tasks

Test Cases

Story Definition of Ready (updated on 12/23/22)

The following criteria must be met in order for the user story to be picked up by the Flexion development team. The user story must:

Process: Flexion developers and designers will test if the story meets acceptance criteria and test cases in Flexion dev and staging environments (“standard testing”). If additional acceptance criteria or testing scenarios are discovered while the story is in progress, a new story should be created, added to the backlog and prioritized by the product owner.

Definition of Done (Updated 5-19-22)

Product Owner

UX

Engineering

ttlenard commented 2 months ago

Test Cases

Mwindo commented 1 month ago

I looked into this briefly. Unfortunately, the issue is with the third-party library react-paginate itself. See https://github.com/AdeleD/react-paginate/issues/459. The options I can think of:

  1. Changing the DOM post-load. This seems terribly clunky.
  2. Forking. This seems high-cost.
  3. Switching to a different library. Again, this seems high-cost.
  4. Pinning to an earlier version, e.g., version 8.1.3. (Per this comment.) This isn't necessarily ideal, but it's much better than the above.
  5. Punting for now and hoping the issue is resolved with a future release. (Although the most recent release is April 2023.)

Depending on the severity of this issue, I think the best options are 4 and 5, but I am open to other suggestions.

Mwindo commented 1 month ago

Unassigning myself for now, but happy to pick back up in a few days.

ttlenard commented 1 week ago

@TomElliottFlexion Everything looks good with the exception of a small typo here. This should be "your".

image.png