flexion / ef-cms

An Electronic Filing / Case Management System.
23 stars 10 forks source link

Reduce padding on Change link for upload component #10479

Open katiecissell opened 1 week ago

katiecissell commented 1 week ago

This ticket is a followup ticket to 10427.

As a user I would like spacing in Dawson to be consistent so that I don't think there is a bug or something wrong.

To make the padding around links more consistent we have been adjusting it in earlier tickets. This ticket will cover adjusting the padding for the Change link and Choose file btn for the file upload component when a file is uploaded. This will apply to all file upload components in Dawson.

Preconditions: none

AC:

3 examples of the padding being too large for this component link.

image.png image.png image.png

Choose file btn (mobile and desktop):

Screenshot 2024-09-13 at 10.37.20 AM.png
En-8 commented 1 week ago

Some extra context as an FYI for whomever picks this up:

As part of 10427, I created a new InlineLink component that's always an <a> under-the-hood and intended for use with inline links that are actually meant for navigation rather than interaction.

Personally, I do not think that component is the right choice for this "Change" button that does actually seem conceptually to be a "button" and not a "link" (even though it's link-styled), so I would look for a different way to solve this. Just beware of making blanket changes to the padding of our custom Button component, since that's used everywhere and changes to padding mess with alignment of various other interact-able elements throughout the app.