flexion / ef-cms

An Electronic Filing / Case Management System.
24 stars 10 forks source link

BUG: Activity Report: Sessions Held not calculating correctly. #10487

Closed ttlenard closed 1 month ago

ttlenard commented 2 months ago

Describe the Bug A clear and concise description of what the bug is.

It seems if a session is unassigned to a Judge, the session is getting added to the Sessions Held counts for all judges on the Activity report. I found this by doing some tests with a judge that was just created in story 10455. When I pulled the activity report for the new judge, I noticed that there were special sessions and a Motion Hearing assigned to her. After looking into it more, Christopher was able to confirm that unassigned sessions are getting counted for all judges. I was able to confirm this by pulling the statistics activity report for multiple judges, and all of the judges also had these sessions in their "Sessions Held" count.

Another (minor) issue that I found was that the sessions held section was pulling in sessions that started tomorrow. From Christopher, "Looking at the code slightly more confirms my suspicion that the "off-by-one" error is a timezone thing. I'm not sure how easy that is to fix: the client "today" might be different than the server "today"."

Business Impact/Reason for Severity medium

In which environment did you see this bug? Test, Staging

Who were you logged in as? Judge users

What were you doing when you discovered this bug? (Using the application, demoing, smoke tests, testing other functionality, etc.) I was testing other functionality when I found this issue.

To Reproduce Steps to reproduce the behavior:

  1. Log in as a test judge user (I was testing with a brand new judge created for testing 10455)
  2. Click on Reports and then select Activity
  3. Input today's date for the end date, and put in a date somewhat close (like a 2 week period?) (I put 9/1/24 - 9/16/24)
  4. Click View Statistics
  5. Notice that the new judge shows that they had 2 special sessions and 0.5 Motion hearings.
  6. If you look at the Trial sessions page for this time frame, you'll see that there were 2 specials and 1 motion/hearing that are unassigned on TEST. These are getting into the Count of any judges Sessions held section on the Activity report and they shouldn't be.
  7. Also - it appears that sessions that I created for tomorrow are showing in the sessions held section. This probably only happens when I view this in the late afternoon due to time zone differences?

Expected Behavior A clear and concise description of what you expected to happen. Unassigned sessions shouldn't be getting counted for selected Judges in the Activity report. Sessions that start tomorrow should not show in the sessions held when I run the report.

Actual Behavior A clear and concise description of what actually happened. Unassigned trial sessions are getting counted for ANY judge that runs the report with those sessions in the time-frame they run the report for. Sessions that start tomorrow are showing in the sessions held when I run the report

Screenshots If applicable, add screenshots to help explain your problem.

New judge - showing 2 specials and a motion/hearing

image.png

Here are the unassigned special sessions:

image.png

Here is the unassigned Motion/hearing:

image.png

Desktop (please complete the following information):

Smartphone (please complete the following information):

Cause of Bug, If Known

Process for Logging a Bug:

Severity Definition:

Definition of Ready for Bugs(Created 10-4-21)

Definition used: A failure or flaw in the system which produces an incorrect or undesired result that deviates from the expected result or behavior. (Note: Expected results are use cases that have been documented in past user stories as acceptance criteria and test cases, and do not include strange behavior unrelated to use cases.)

The following criteria must be met in order for the development team to begin work on the bug.

The bug must:

Process: If the unexpected results are new use cases that have been identified, but not yet built, new acceptance criteria and test cases should be captured in a new user story and prioritized by the product owner.

If the Court is not able to reproduce the bug, add the “Unable to reproduce” tag. This will provide visibility into the type of support that may be needed by the Court. In the event that the Court cannot reproduce the bug, the Court will work with Flexion to communicate what type of troubleshooting help may be needed.

Definition of Done (Updated 4-14-21)

Product Owner

Engineering