Investigate new PDF upload errors and enhance error message to users

[ttlenard]

As a DAWSON User, so that I understand what I need to do to ensure my PDF uploads without error, I need better error messaging so that I can upload my PDF into DAWSON.

Stories #10001, #10002, and #10003 were completed recently. These stories enhanced the error messaging that the user received if they attempted to upload a non-compliant PDF into DAWSON. In addition, the error message in the logs was also enhanced. We implemented a "catch all" error message and now that we have better error messaging in the logs, we are seeing some new errors that we didn't see before. Users get a generic "There is a problem uploading the file. Try again later.", so we aren't providing them with any direction on how to fix their file.

Additional review of the root cause of the error messages is needed. Depending on the root cause, it may be determined that we need to add additional messaging to users so that they can fix the issue and submit the document successfully

Pre-Conditions

Acceptance Criteria

• Root cause of the error messages seen in the logs is identified. See Screen captures below
• If it is determined that a new error message is necessary, the pop-up error modal in the same format as what was implemented in stories #10001, #10002, and #10003.

Notes

Errors seen in the logs:

Tasks

Test Cases

Story Definition of Ready (updated on 12/23/22)

The following criteria must be met in order for the user story to be picked up by the Flexion development team. The user story must:

• [ ] Is framed in business/user need, the value has been addressed.
• [ ] Includes acceptance criteria
• [ ] Has been refined
• [ ] Pre conditions have been satisfied.

Process: Flexion developers and designers will test if the story meets acceptance criteria and test cases in Flexion dev and staging environments (“standard testing”). If additional acceptance criteria or testing scenarios are discovered while the story is in progress, a new story should be created, added to the backlog and prioritized by the product owner.

Definition of Done (Updated 5-19-22)

Product Owner

• [ ] Acceptance criteria have been met and validated on the Court's migration environment
• [ ] Add scenario to testing document, if applicable (https://docs.google.com/spreadsheets/d/1FUHKC_YrT-PosaWD5gRVmsDzI1HS_U-8CyMIb-qX9EA/edit?usp=sharing)

UX

• [ ] Business test scenarios have been refined to meet all acceptance criteria
• [ ] Usability has been validated
• [ ] Wiki has been updated (if applicable)
• [ ] Story has been tested on a mobile device (for external users only)

Engineering

• [ ] Automated test scripts have been written, including visual tests for newly added PDFs.
• [ ] Field level and page level validation errors (front-end and server-side) integrated and functioning.
• [ ] Verify that language for docket record for internal users and external users is identical.
• [ ] New screens have been added to pa11y scripts.
• [ ] All new functionality verified to work with keyboard and macOS voiceover https://www.apple.com/voiceover/info/guide/_1124.html.
• [ ] READMEs, other appropriate docs, and swagger/APIs fully updated.
• [ ] UI should be touch optimized and responsive for external only (functions on supported mobile devices and optimized for screen sizes as required).
• [ ] Interactors should validate entities before calling persistence methods.
• [ ] Code refactored for clarity and to remove any known technical debt.
• [ ] If new docket entries have been added as seed data to efcms-local.json, 3 local s3 files corresponding to that docketEntryId have been added to web-api/storage/fixtures/s3/noop-documents-local-us-east-1
• [ ] Acceptance criteria for the story has been met.
• [ ] If there are special instructions in order to deploy into the next environment, add them as a comment in the story.
• [ ] If the work completed for the story requires a reindex without a migration, or any other special deploy steps, apply these changes to the following flexion branches:
  • [ ] experimental1
  • [ ] experimental2
  • [ ] experimental3
  • [ ] experimental4
  • [ ] experimental5
  • [ ] experimental6
  • [ ] develop
• [ ] Reviewed by UX on a deployed environment.
• [ ] Reviewed by PO on a deployed environment. Can be deployed to the Court's test environment if prod-like data is required. Otherwise deployed to any experimental environment.
• [ ] Deployed to the Court's staging environment.

[ttlenard]

If devs determine that new error message modals will be added with this story, then I will add in test cases. If adding new error message modals is split out into a separate story, then we can skip test cases for this story.

[Mwindo]

A few notes for devs:

• The first two FileReader errors seem to indicate something like the following: The user began the upload process, but while the validation was occurring they renamed, moved, or edited the file. I can re-create similar errors locally by throttling my browser and quickly updating a selected file. However, this doesn't seem like something that should happen at all often. I wonder if there are issues with slow browsers somehow. For instance, even though I resolved it, this was something I noticed when testing locally; maybe slow browsers still have a similar issue.
• The private name, k.split, and structuredClone errors (images five through nine and also eleven, unless I miscounted) are outdated browser clients. pdfjs is looking for ES2022 or later. A few options: we can add a message like, "You should update your browser"; we can transpile the pdfjs package; we can load the legacy version and modern version of pdfjs appropriately depending on the client. (I personally prefer the latter two solutions, which do not restrict users of the system who may not have the hardware to upgrade. Note that the restriction is because of pdfjs, not because of any real business need to restrict the user. Without pdfjs validation, they could upload a proper PDF just fine.)
• The other errors--the dynamic import and uninitialized variable errors--are more opaque to me. I would not be surprised if they are related to outdated browsers as well, but I am unsure.

Some references:

• structuredClone error: https://github.com/mozilla/pdf.js/issues/14729
• private name error: https://github.com/mozilla/pdf.js/issues/14327
• Outdated client info: https://stackoverflow.com/questions/73653874/pdfjs-not-working-in-safari-blank-page-how-to-solve-issue
• Pdj.js getting starting notes, which discuss legacy vs. modern builds: https://github.com/mozilla/pdf.js/tree/master?tab=readme-ov-file#getting-started