flexn-io / create

Build apps for web, TVs, desktops, consoles, wearables and more. Developer friendly UI library targeting all form factors platforms. Another notable feature is providing focus management for TVs which very easy to implement using Create.
https://create.flexn.org
MIT License
26 stars 6 forks source link

[AndroidTV, fireTV] flexn/template has badly styled app icon #31

Closed pauliusguzas closed 1 year ago

pauliusguzas commented 2 years ago

rnv version: 0.36.1-canary.2 flexn template version: 0.16.0

How to repro:

  1. Install app on device
  2. Navigate to device home page to see all apps

Expected: App icon is styled properly

AndroidTV current icon: Screenshot 2022-06-23 at 09 54 42

fireTV current icon: 153580627-8ceb6739-d18b-413e-b8a4-e45667a10a18

locksten commented 2 years ago

Could not reproduce on emulators:

Screen Shot 2022-08-29 at 15 40 27 Screen Shot 2022-08-29 at 15 38 25
aurimasmi commented 2 years ago

qa to be checked if it's still the case

pauliusguzas commented 2 years ago

Can't test firetv as there is a bug but atv still has this issue on rnv 0.36.2-canary.4 and flexn/template 0.18.0-alpha.4

locksten commented 2 years ago

Running @flexn/template@0.18.0-alpha.4 with rnv@0.36.2-canary.4 on a tvOS 15.4 simulator, I get this (could it be a simulator vs device difference? Or am I running it somehow differently?):

Screen Shot 2022-09-09 at 16 50 13 Screen Shot 2022-09-09 at 16 50 20
pauliusguzas commented 2 years ago

@locksten I think we are running templates in some different way (my template always shows package.json version while yours I see is template version). I am installing correct rnv version, then doing rnv new, then selecting @flexn/template, then choosing certain version, and then simply running it

locksten commented 2 years ago

I did what you described @pauliusguzas and still didn't experience the problem 🤷

tv icon tvos icon 1 tvos icon 2

androidtv icon 1 android tv icon 2
locksten commented 2 years ago

Reproduced on Android TV 10 (with rnv@0.36.2-canary.4 and @flexn/template 0.17.0)

Screen Shot 2022-09-16 at 10 53 30

aurimasmi commented 1 year ago

Latest renative needs to be implemented and New deployments is needed utilising our new release pipelines