search

flexn-io / create

Build apps for web, TVs, desktops, consoles, wearables and more. Developer friendly UI library targeting all form factors platforms. Another notable feature is providing focus management for TVs which very easy to implement using Create.
https://create.flexn.org
MIT License
26 stars 6 forks source link

fix(flexn/template): tv with bundle assets error #45

Closed locksten closed 1 year ago

locksten commented 1 year ago

Fixes #44

pauliusguzas commented 1 year ago

@locksten supposedly does not fix the issue (can be seen from the actions)

locksten commented 1 year ago

@pauliusguzas it's due to the "Now Try Me!" button test failing:

Screen Shot 2022-09-16 at 12 16 29

I fixed the preceding test not properly returning to the home screen, but for some reason await FlexnRunner.expectToBeDisplayedById('template-carousels-screen-container'); still fails, even though the carousels screen is displayed, and the same check in an earlier test succeeds. Any idea what could be causing this @pauliusguzas ?

https://user-images.githubusercontent.com/9592076/190617838-4af9032a-3f2d-4030-888e-d79d7c23da10.mp4

pauliusguzas commented 1 year ago

Will investigate it, though atv I see is failing on all tests

locksten commented 1 year ago

@pauliusguzas I ran yarn e2e-template-androidtv locally with just the await FlexnRunner.pressButtonRight(1); fix and it passed all tests:

https://user-images.githubusercontent.com/9592076/190659873-5bb5ab93-da0c-4e19-8a70-3a781c515980.mp4

pauliusguzas commented 1 year ago

@locksten Yeah the issue is with template, drawer does not close automatically and that causes wrong page opening on last test. I can confirm that your fix is valid, basically template is broken, tests themself do not need to be changed. It is expected to fail if the app is broken