flexn-io / create

Build apps for web, TVs, desktops, consoles, wearables and more. Developer friendly UI library targeting all form factors platforms. Another notable feature is providing focus management for TVs which very easy to implement using Create.
https://create.flexn.org
MIT License
26 stars 6 forks source link

Fix: Incorrect scroll behavior #86

Closed aurimasmi closed 1 year ago

aurimasmi commented 1 year ago

PR meant to fix:

CleanShot2023-05-26at09 05 22

CleanShot2023-05-26at09 07 38

Extra:

If scrollview has been requested particular scroll target and it receives more requests with the same target now any subsequent request is ignored and scrollview is allowed to finish first one. That was causing scroll slowdown reaching the end of target

pauliusguzas commented 1 year ago

https://github.com/flexn-io/create/assets/65670660/54fd4384-0dcc-40f2-90d3-5cf74553362e

  1. tvOS only - When 1st row is on 1st packshot and 2nd row is scrolled, going down from first row has some jumping
  2. ATV and tvOS - When 1st row is on last packshot, going down from first row major jumping
  3. ATV and tvOS - Can't fully focus on last item in row
  4. tvOS only - Not sure if this focus behaviour is acceptable as it doesn't seem to focus item which is above/below https://github.com/flexn-io/create/assets/65670660/7380b51c-a452-402d-834d-02dde6236aad
  5. ATV only - when scrolling left/right horizontal scroll tab is visible
aurimasmi commented 1 year ago

@pauliusguzas how would you expect then 1 and 2 to be working? since focus stick to the left and from row above you focused in the middle so what focus does it trying to stick to the left again

aurimasmi commented 1 year ago

Anyway all these comments which you described are not related with PR. Let's keep PR's simple and pointing to the issues it suppose to solve. Can you confirm that those issues which is described in description is resolved?

pauliusguzas commented 1 year ago

Yes

aurimasmi commented 1 year ago

Thanks, I'll raise PR's against your reported issues