search

flexn-io / renative

🚀🚀🚀 Unified Development Platform for iOS, tvOS, Android, Android TV, Android Wear, Web, Tizen TV, Tizen Watch, Tizen Mobile, LG webOS, macOS/OSX, Windows, KaiOS, FirefoxOS Firefox TV platforms
https://renative.org
MIT License
1.8k stars 180 forks source link

Upgrade webos support #1337

Closed Marius456 closed 1 month ago

Marius456 commented 8 months ago

Is your feature request related to a problem? Please describe. The WebOS emulator depends on VirtualBox to run itself. The VirtualBox doesn't support Mac M1/M2. There is a new option that don't depend on VirtualBox. The WebOS simulator.

Describe the solution you'd like Update renative dependencies so it would support WebOS simulator instead of an emulator.

pauliusguzas commented 7 months ago

target list logic still displays emulator

 $ npx rnv target list -p webos - Done! 🚀
┌──────────────────────────────────────────────────────────────────────────────┐
│  🚀  SUMMARY | 1/31/2024, 3:33:02 PM                                         │
│  $ npx rnv target list -p webos                                              │
├──────────────────────────────────────────────────────────────────────────────┤
│  ReNative Version: 1.0.0-rc.10                                               │
│  Project Name ($package.name): desimt                                        │
│  Project Version ($package.version): 0.1.0                                   │
│  Workspace ($.workspaceID): rnv                                              │
│  Platform (-p): webos                                                        │
│  Engine ($.platforms.webos.engine): engine-core                              │
│  App Config (-c): app                                                        │
│  Build Scheme (-s): debug                                                    │
│  Env Info: darwin | x64 | node v18.17.0                                      │
│  Executed Time: 0h:0m:3s:160ms                                               │
│                                                                              │
│
WebOS Targets:
 [1]> webOS_TV | prisoner@192.168.1.24:9922
 [2]> emulator | developer@127.0.0.1:6622
 [3]> webOS_TV2 | prisoner@192.168.1.30:9922
│                                                                              │
└──────────────────────────────────────────────────────────────────────────────┘
pauliusguzas@MBP-de-Flexn desimt %
pauliusguzas commented 7 months ago
  1. npx rnv target launch -p webos -> choose Pick from available targets... -> simulator launches (expected: target list is displayed)
  2. user has defined some random simulator name in renative.json -> npx rnv target launch -p webos -> choose that random name -> simulator launches (expected: target list is displayed)
  3. simulator is open -> npx rnv target launch -p webos > choose Pick from available targets... -> command exists successfully (expected: some error saying simulator is open)
  4. npx rnv target launch -p webos -t some_random_name` -> simulator launches (expected: target list is displayed)
pauliusguzas commented 6 months ago 
pauliusguzas@MBP-de-Flexn template-starter % npx rnv target launch -p webos

┌──────────────────────────────────────────────────────────────────────────────┐
│        ██████╗ ███████╗███╗   ██╗ █████╗ ████████╗██╗██╗   ██╗███████╗       │
│        ██╔══██╗██╔════╝████╗  ██║██╔══██╗╚══██╔══╝██║██║   ██║██╔════╝       │
│        ██████╔╝█████╗  ██╔██╗ ██║███████║   ██║   ██║██║   ██║█████╗         │
│        ██╔══██╗██╔══╝  ██║╚██╗██║██╔══██║   ██║   ██║╚██╗ ██╔╝██╔══╝         │
│        ██║  ██║███████╗██║ ╚████║██║  ██║   ██║   ██║ ╚████╔╝ ███████╗       │
│        ╚═╝  ╚═╝╚══════╝╚═╝  ╚═══╝╚═╝  ╚═╝   ╚═╝   ╚═╝  ╚═══╝  ╚══════╝       │
│        Version: 1.0.0-rc.12 🚀 Firing up!...                                 │
│        https://renative.org/ | Start Time: 3/4/2024, 1:46:46 PM               │
│        $ npx rnv target launch -p webos                                      │
└──────────────────────────────────────────────────────────────────────────────┘
[ log ] registerEngine:engine-core[1]
[ log ] configureRuntimeDefaults[1] appId:undefined
[ log ] checkAndMigrateProject2[1]
[ log ] loadPluginTemplates[1]
[ log ] parseRenativeConfigs[1]
[ log ] getWorkspaceDirPath[1]
[ log ] generatePlatformTemplatePaths[1]
[ log ] checkAndBootstrapIfRequired[1]
[ log ] loadIntegrations[1]
[ log ] loadEngines[1]
[ log ] loadEnginePluginDeps[1]
[ log ] loadEnginePackageDeps[1]
[ log ] registerEngine:engine-rn-web[1]
[ log ] findSuitableTask[1]
[ info ] Current Engine: engine-core path: /Users/pauliusguzas/Desktop/renative/renative/packages/engine-core/lib
[ log ] registerMissingPlatformEngines[1]
[ log ] initializeTask[1] target launch
[ task ] => [target launch]
[ task ] [target launch] taskTargetLaunch[1]
[ log ] [target launch] checkAndConfigureSdks[1]
[ log ] [target launch] checkAndConfigureWebosSdks:webos[1]
[ task ] => [target launch] => [workspace configure]
[ task ] [workspace configure] taskWorkspaceConfigure[1]
[ task ] <= [target launch] <= workspace configure
? Which target to use? Pick from available targets...
[ log ] [target launch] checkSdk[1]
[ log ] [target launch] checkWebosSdk[1]
[ log ] [target launch] _isSdkInstalled[1]
[ log ] [target launch] launchWebOSimulator[1] true
[ warn ] [target launch] Target with name true does not exist. You can update it here: /Users/pauliusguzas/.rnv/renative.json
[ log ] [target launch] launchWebOSimulator[2]
? Select the simulator you want to launch webOS_TV_23_Simulator_1.3.0
✔ Executing: open /opt/webOS_TV_SDK/Simulator/webOS_TV_23_Simulator_1.3.0/webOS_TV_23_Simulator_1.3.0.app
[ success ] [target launch] Succesfully launched webOS_TV_23_Simulator_1.3.0
[ task ] <= target launch

 $ npx rnv target launch -p webos - Done! 🚀
┌──────────────────────────────────────────────────────────────────────────────┐
│  🚀  SUMMARY | 3/4/2024, 1:46:58 PM                                          │
│  $ npx rnv target launch -p webos                                            │
├──────────────────────────────────────────────────────────────────────────────┤
│  ReNative Version: 1.0.0-rc.12                                               │
│  Project Name ($package.name): @rnv/template-starter                         │
│  Project Version ($package.version): 1.0.0-rc.12                             │
│  Workspace ($.workspaceID): rnv                                              │
│  Platform (-p): webos                                                        │
│  Engine ($.platforms.webos.engine): engine-core                              │
│  App Config (-c): template                                                   │
│  Build Scheme (-s): debug                                                    │
│  Env Info: darwin | x64 | node v18.17.0                                      │
│  Executed Time: 0h:0m:12s:614ms                                              │
│                                                                              │
│ [ warn ] [target launch] Target with name true does not exist. You can update it here: /Users/pauliusguzas/.rnv/renative.json
│ [ success ] [target launch] Succesfully launched webOS_TV_23_Simulator_1.3.0
│                                                                              │
└──────────────────────────────────────────────────────────────────────────────┘
pauliusguzas@MBP-de-Flexn template-sta

this log is not correct, there is no such name as "true" set │ [ warn ] [target launch] Target with name true does not exist. You can update it here: /Users/pauliusguzas/.rnv/renative.json

GabrieleKaceviciute commented 3 months ago

1.0.0-rc.19

┌─────────────────────────────────────────────────────────────────┐ │ ██████╗ ███████╗███╗ ██╗ █████╗ ████████╗██╗██╗ ██╗███████╗ │ │ ██╔══██╗██╔════╝████╗ ██║██╔══██╗╚══██╔══╝██║██║ ██║██╔════╝ │ │ ██████╔╝█████╗ ██╔██╗ ██║███████║ ██║ ██║██║ ██║█████╗ │ │ ██╔══██╗██╔══╝ ██║╚██╗██║██╔══██║ ██║ ██║╚██╗ ██╔╝██╔══╝ │ │ ██║ ██║███████╗██║ ╚████║██║ ██║ ██║ ██║ ╚████╔╝ ███████╗ │ │ ╚═╝ ╚═╝╚══════╝╚═╝ ╚═══╝╚═╝ ╚═╝ ╚═╝ ╚═╝ ╚═══╝ ╚══════╝ │ │ $ npx rnv target list -p webos │ └─────────────────────────────────────────────────────────────────┘ info: Current engine: @rnv/engine-rn-web (./node_modules/@rnv/engine-rn-web) task: ○ target list ↺1 task: ○ workspace configure ↺1 task: ✔ workspace configure ✔ Executing: /Users/gabriele/webOS_TV_SDK/CLI/bin/ares-device-info -D task: ✔ target list ┌─────────────────────────────────────────────────────────────────┐ │ ✔ SUMMARY | 5/22/2024, 10:36:18 AM | rnv@ │ │ $ npx rnv target list -p webos │ ├─────────────────────────────────────────────────────────────────┤ │ Project: naujas@0.1.0 │ │ Workspace: rnv │ │ Platform (-p): webos │ │ Engine: @rnv/engine-rn-web │ │ App Config (-c): app │ │ Build Scheme (-s): debug │ │ Env Info: darwin | arm64 | node v18.19.0 │ │ Executed Time: 0h:0m:3s:464ms │ │ WebOS Targets: [1]> emulator | (default) [2]> webOS_TV_UN74003LB | prisoner@192.168.1.24:9922 [3]> webosTV | prisoner@192.168.1.30:9922 [4]> webOS_TV_23_Simulator_1.3.0 | simulator └─────────────────────────────────────────────────────────────────┘ ➜ naujas git:(master)

- try to run `npx rnv target launch -p webos` when simulator is already launched -> summary shows that simulator launched successfully, although it should show error

➜ naujas git:(master) ✗ npx rnv target launch -p webos

┌─────────────────────────────────────────────────────────────────┐ │ ██████╗ ███████╗███╗ ██╗ █████╗ ████████╗██╗██╗ ██╗███████╗ │ │ ██╔══██╗██╔════╝████╗ ██║██╔══██╗╚══██╔══╝██║██║ ██║██╔════╝ │ │ ██████╔╝█████╗ ██╔██╗ ██║███████║ ██║ ██║██║ ██║█████╗ │ │ ██╔══██╗██╔══╝ ██║╚██╗██║██╔══██║ ██║ ██║╚██╗ ██╔╝██╔══╝ │ │ ██║ ██║███████╗██║ ╚████║██║ ██║ ██║ ██║ ╚████╔╝ ███████╗ │ │ ╚═╝ ╚═╝╚══════╝╚═╝ ╚═══╝╚═╝ ╚═╝ ╚═╝ ╚═╝ ╚═══╝ ╚══════╝ │ │ $ npx rnv target launch -p webos │ └─────────────────────────────────────────────────────────────────┘ info: Current engine: @rnv/engine-rn-web (./node_modules/@rnv/engine-rn-web) task: ○ target launch ↺1 task: ○ workspace configure ↺1 task: ✔ workspace configure ? Which target to use? webOS_TV_23_Simulator_1.3.0 (project default) info: ✔ Succesfully launched webOS_TV_23_Simulator_1.3.0 task: ✔ target launch ┌─────────────────────────────────────────────────────────────────┐ │ ✔ SUMMARY | 5/22/2024, 3:35:18 PM | rnv@ │ │ $ npx rnv target launch -p webos │ ├─────────────────────────────────────────────────────────────────┤ │ Project: naujas@0.1.0 │ │ Workspace: rnv │ │ Platform (-p): webos │ │ Engine: @rnv/engine-rn-web │ │ App Config (-c): app │ │ Build Scheme (-s): debug │ │ Env Info: darwin | arm64 | node v18.19.0 │ │ Executed Time: 0h:0m:1s:142ms │ │ info: ✔ Succesfully launched webOS_TV_23_Simulator_1.3.0 └─────────────────────────────────────────────────────────────────┘ ➜ naujas git:(master) ✗

GabrieleKaceviciute commented 3 months ago

It was decided that this behavior (https://github.com/flexn-io/renative/issues/1337#issuecomment-2124117907) is expected