flexn-io / renative

🚀🚀🚀 Unified Development Platform for iOS, tvOS, Android, Android TV, Android Wear, Web, Tizen TV, Tizen Watch, Tizen Mobile, LG webOS, macOS/OSX, Windows, KaiOS, FirefoxOS Firefox TV platforms
https://renative.org
MIT License
1.82k stars 180 forks source link

Boolean properties is being ignored in AndroidManifest_xml config #1565

Closed aurimasmi closed 3 months ago

aurimasmi commented 6 months ago

Describe the bug Boolean properties(and maybe numbers) is ignored when updating android properties in Manifest file. Example:

"templateAndroid": {
    "AndroidManifest_xml": {
        "children": [
            {
                ....
                "android:usesCleartextTraffic": false,
                "android:allowBackup": false
            }
        ]
    }
}

"android:usesCleartextTraffic": false and "android:allowBackup": false is ignored unless you transform to string: "android:allowBackup": "false"

To Reproduce Steps to reproduce the behavior:

  1. Add any config in renative.json AndroidManifest_xml which would have true or false value

Expected behavior

I should be able to use boolean values instead of stringified ones

Environment

ElenaDiachenko commented 5 months ago

This issue was fixed in 1.0.0-rc.13.