flexn-io / renative

🚀🚀🚀 Unified Development Platform for iOS, tvOS, Android, Android TV, Android Wear, Web, Tizen TV, Tizen Watch, Tizen Mobile, LG webOS, macOS/OSX, Windows, KaiOS, FirefoxOS Firefox TV platforms
https://renative.org
MIT License
1.82k stars 180 forks source link

Cannot activate hermes #885

Closed matiasmateu closed 3 months ago

matiasmateu commented 2 years ago

Describe the bug Hermes cannot be enabled on Android

To Reproduce 1 - Created a new blank RNV project ( https://github.com/matiasmateu/renativeHermes )

2 - Added reactNativeEngine = "hermes" to platforms.android ( https://github.com/matiasmateu/renativeHermes/blob/ec21fdcfb224e35108ae09bf6e13f01bb5c19f64/renative.json#L4 )

2.1 - I can see in platformBuilds -> build.grade: enableHermes: true && new deps debugImplementation files("{pathToProject}/emptyRenative/node_modules/hermes-engine/android/hermes-debug.aar") releaseImplementation files("{pathToProject}/emptyRenative/node_modules/hermes-engine/android/hermes-release.aar")

3 - However, global.HermesInternal is always undefined ( https://github.com/matiasmateu/renativeHermes/blob/ec21fdcfb224e35108ae09bf6e13f01bb5c19f64/src/app/index.js#L6 )

Expected behavior global.HermesInternal should not be undefined

Desktop:

kevinbtesar commented 2 years ago

Having this issue as well

GabrieleKaceviciute commented 1 year ago

@matiasmateu thanks for reporting this issue, is this still reproduced on latest version?

pauliusguzas commented 11 months ago

Actual hermes engine is working as default but can't override it with other engines on 1.0.0-rc.6 new project

ElenaDiachenko commented 10 months ago

@GabrieleKaceviciute @pauliusguzas 1.0.0-rc.7. Hermes works in the repo and in new project as well.

How to check: modify renative. json by set other engine. For example:

"platforms": { "android":{ "reactNativeEngine": "v8-android" } },