search

flexoffer / flexoffer-specifications

Specifications of FlexOffer
2 stars 2 forks source link

removal of 'endAfter/BeforeTime/Interval ' #29

Open cerne739 opened 1 year ago

cerne739 commented 1 year ago

'endAfter/BeforeTime/Interval' – the parameter pairs are relevant only when ‘minDuration’/’maxDuration’ are introduced in flexOfferProfileConstraint, otherwise are redundant to the ‘startAfter/Before’ parameters. To simplify the protocol description, would it be better to (temporaly) remove them ?

DuneSe commented 1 year ago

We should indicate them as optional, not mandatory Gregor will write a paragraph to clarify when they should be used

cerne739 commented 1 year ago

The parameters are already 'optional' Additional description proposal: The parameters are used when time flexibility is being described (startAfterTime is not equal to startBeforeTime) and minDuration is not equal to maxDuration in FlexOfferSlice element

cerne739 commented 1 year ago

Hello, Regarding issue #29 I propose the following description: »The parameters are used when time flexibility is being described (startAfterTime is not equal to startBeforeTime) and minDuration is not equal to maxDuration in FlexOfferSlice element«

The parameters are already described as optional. Is there any other open issue from my side ? Best regards Gregor

From: DuneSe @.> Sent: Thursday, April 13, 2023 10:53 AM To: flexoffer/flexoffer-specifications @.> Cc: Černe Gregor @.>; Author @.> Subject: Re: [flexoffer/flexoffer-specifications] removal of 'endAfter/BeforeTime/Interval ' (Issue #29)

We should indicate them as optional, not mandatory

— Reply to this email directly, view it on GitHubhttps://github.com/flexoffer/flexoffer-specifications/issues/29#issuecomment-1506593048, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A565HYMBZ3I6AEA72CTKLZLXA65FTANCNFSM6AAAAAAWKT5DGU. You are receiving this because you authored the thread.Message ID: @.**@.>>