search

flexport / quarantine

Quarantine flaky Ruby Rspec tests
MIT License
65 stars 21 forks source link

Fix local test example in README #19

Closed geoffharcourt closed 3 years ago

geoffharcourt commented 4 years ago

The local test example had invalid RSpec syntax. It also looks like Random.rand(3) won't return 3 33% of the time (the result gets converted to an integer so it's always (0, 1, or 2 unless the random number was exactly 3.0) so it gets adjusted to be 1 to allow the example to be more easily testable.

geoffharcourt commented 3 years ago

Hi @davidlee1435 I just rebased to resolve the merge conflict since you last approved. I think this can be merged now.

alekstorm commented 3 years ago

Thanks!