search

flexsurfer / lein-re-frisk

A Leiningen plugin to start a web server for the remote debug re-frame applications using re-frisk.
7 stars 3 forks source link

AOT compiling breaks projects that use recent tools.reader features #2

Closed danielneal closed 7 years ago

danielneal commented 7 years ago

Because the project is AOT compiled, it bundles an older version of tools.reader in a way that can not be overridden.

This breaks any projects that use more recent features of tools.reader, such as clojure 1.9's namespaced map syntax #foo{:bar 1}

I've put up a repro demonstrating the problem here: https://github.com/danielneal/refrisk-dependency-issue

If the project was not AOT compiled, end users would be able to use :exclusions to use their version of tools.reader, but at the moment this is impossible.

It can be fixed by removing :main here (which I've tried and works) https://github.com/flexsurfer/lein-re-frisk/blob/master/re-frisk-sidecar/project.clj#L20

Or possibly marking it as ^:skip-aot but I haven't tried that. https://github.com/technomancy/leiningen/blob/master/sample.project.clj#L210-L217

flexsurfer commented 7 years ago

thank you @danielneal it's really helpful, i forget to remove :main, it was for test purposes :( will do it later today!

danielneal commented 7 years ago

Awesome thanks!

flexsurfer commented 7 years ago

fixed in 0.5.1, @danielneal please check, and thanks :)