search

flexsurfer / re-frisk

Take full control of re-frame app
https://flexsurfer.github.io/conduit-re-frisk-demo/
456 stars 29 forks source link

Don't use (.alert) when window is refreshed #28

Closed timgilbert closed 4 years ago

timgilbert commented 7 years ago

It would be nice if the external-window version of re-frisk didn't fire a window.alert() when the main window is refreshed - it winds up stealing focus and making the user click a button right when the user is trying to interact with the main window. I'd suggest maybe a (.warn js/console) instead, or possibly changing the external window so that it displays a prominent message telling the user that the debugger is not connected to the main app.

I could probably slap together a PR for this in a few days if you agree. Thanks!

flexsurfer commented 7 years ago

hi. thank you, yes using an alert not a good idea, but a developer should know that re-frisk doesn't work anymore, maybe better show a message in div on top

flexsurfer commented 4 years ago

fixed in v1