search

flexsurfer / re-frisk

Take full control of re-frame app
https://flexsurfer.github.io/conduit-re-frisk-demo/
456 stars 29 forks source link

Metadata leak in re-frisk #38

Closed stoeckley closed 6 years ago

stoeckley commented 6 years ago

Not sure if this should be put here, but re-frisk is possible the culprit for this metadata leak:

https://github.com/Day8/re-frame/issues/365#issuecomment-315356432

Also, note the very large compile time introduced by re-frisk.

flexsurfer commented 6 years ago

yeah, thanks @astoeckley . it's because i'm using cljs.js https://github.com/flexsurfer/re-frisk-shell/blob/master/src/re_frisk_shell/core.cljs#L6, looks like it's better to do not include this by default

stoeckley commented 6 years ago

Thanks, do you know if this will be a quick fix? If not, I will remove re-frisk from my project until it is resolved.

flexsurfer commented 6 years ago

unfortunately it's not quick, so you can use 0.3.2 if you need re-frisk, or remove it

stoeckley commented 6 years ago

Was 0.3.2 before you made a big change to cause this particular issue? Anything else that is notably different in 0.3.2?

flexsurfer commented 6 years ago

yes, 0.3.2 has the same functionality, but without this cljs runtime compiler

stoeckley commented 6 years ago

Incidentally, perhaps the reason that my advanced compilation build with re-frisk takes 200 seconds is that somehow re-frisk is still entering the picture there, despite that the reframe template seems to be preventing that. cljs.js is not compatible with advanced optimizations.

mike-thompson-day8 commented 6 years ago

We have stepped back to 0.3.2 also. This is a pretty nasty trap. Thanks for highlighting it @astoeckley

flexsurfer commented 6 years ago

@mike-thompson-day8 sorry for that, i'm working only with remote version, so i haven't seen this problem, and no one report the problem long time, i will fix this asap this weekend, i'm reworking UI atm, using re-com, but faced performance issues in safari, and bug with splitter, could you give advice should i continue with re-com for re-frisk or better leave old UI for now? i know you don't recommend it for safari , thanks

mike-thompson-day8 commented 6 years ago

I think it may be safest to stick with the old UI.

re-com works really well for us, but we're on Chrome.

flexsurfer commented 6 years ago

fixed in 0.5.0