search

flexsurfer / re-frisk

Take full control of re-frame app
https://flexsurfer.github.io/conduit-re-frisk-demo/
456 stars 29 forks source link

re-frisk does not work with shadow-cljs v2.15.13 #67

Closed liquidz closed 2 years ago

liquidz commented 2 years ago

Expected

re-frisk works with shadow-cljs v2.15.13

Actual

the following error occurs

Uncaught TypeError: Cannot read properties of undefined (reading 'set')
    at re_frisk$ui$mount_internal (re_frisk.ui.js:93)

How to fix

re-frisk.ui uses goog.object without requiring, so I fixed to require goog.object.

liquidz commented 2 years ago

@flexsurfer Thank you for releasing ver 1.5.2! If you have a time, I'm happy if you deploy 1.5.2 to clojars :) https://clojars.org/re-frisk

flexsurfer commented 2 years ago

@liquidz done. i thought that it was deployed, but it seems there was some error, so re-deployed it now

liquidz commented 2 years ago

@flexsurfer Thank you so much!