search

flexsurfer / re-frisk

Take full control of re-frame app
https://flexsurfer.github.io/conduit-re-frisk-demo/
456 stars 29 forks source link

Add aternative hide/show shortcut key to init settings #75

Open sirmspencer opened 1 year ago

sirmspencer commented 1 year ago

For example use ctrl+g.

ctrl+h is a common key for plug-ins. Allowing it to change would help with conflicts.

flexsurfer commented 1 year ago

i believe ctrl+h is used in re-frame-10x, do you know how it works for your team who works with it ?

sirmspencer commented 1 year ago

Yes, ctrl+h is used in re-frame-10x. It means we cant load both plugins at the same time.

sirmspencer commented 1 year ago

Apparently ctrl+h is also the history shortcut for firefox, so that interferes as well.

sirmspencer commented 1 year ago

Updated title. I was thinking that it would be configurable and not just changed to a different key that could be a different conflict.

flexsurfer commented 1 year ago

Apparently ctrl+h is also the history shortcut for firefox, so that interferes as well.

but how it works for re-frame-10x then? do they have a solution ?

sirmspencer commented 1 year ago

Apparently ctrl+h is also the history shortcut for firefox, so that interferes as well.

but how it works for re-frame-10x then? do they have a solution ?

Good question, they cannot use firefox, so they use chrome.

sirmspencer commented 1 year ago

Are you ok with this option if I am able to create the PR?

flexsurfer commented 1 year ago

yes sure, PRs are welcomed , thank you