Consider using shadow DOM to prevent embedded re-frisk from affecting the app

flexsurfer / re-frisk

Take full control of re-frame app

https://flexsurfer.github.io/conduit-re-frisk-demo/

456 stars 29 forks source link

Consider using shadow DOM to prevent embedded re-frisk from affecting the app #78

Open p-himik opened 1 year ago

p-himik commented 1 year ago

Not sure whether you have considered it before, but FWIW that's how re-frame-10x does it.

p-himik commented 1 year ago

Although now that I have tried it, it seems that the embedded route is even less viable. Re-frisk has dependencies that are commonly found in apps or other libraries, and those are not vendored in (how re-frame-10x also does). Might not be a problem in the majority of cases, but just now I got a warning from an older version of re-com that uses some deprecated functionality in a newer Reagent. Some other potential issues might be proper errors that would be hard to debug.