search

flexsurfer / re-frisk

Take full control of re-frame app
https://flexsurfer.github.io/conduit-re-frisk-demo/
456 stars 29 forks source link

moved to a namespaced subscription #8

Closed stumitchell closed 7 years ago

stumitchell commented 7 years ago

In this patch I have changed the :db subscription to ::db (a namespaced subscription) so that it won't conflict with a subscription in projects that are using this library.

stumitchell commented 7 years ago

please give this a test though as I haven't

flexsurfer commented 7 years ago

@stumitchell hi, thank you, how it can conflict with a subscription in projects?

stumitchell commented 7 years ago

As re-frame uses a global registry of susbscriptions if someone is using :db as a subscription in their project and it points somewhere different there will be a conflict with the re-frisk version of this subscription.

flexsurfer commented 7 years ago

ok,i understand, just returned from vacation, and do not immediately involved, you right, thank you