search

flexxnn / sequelize-auto-migrations

Migration generator && runner for sequelize
MIT License
258 stars 166 forks source link

Wrap migrations in transaction #52

Open Scimonster opened 5 years ago

Scimonster commented 5 years ago

Each migration should ideally run in a transaction, to avoid a situation of a migration being partially applied.

PaulMest commented 5 years ago

I like this suggestion. One thing to note, though, is that while this is possible with Postgres, it may not be supported on other popular RDBMS platforms.

Scimonster commented 5 years ago

I tested with mysql and sqlite

On Mon, Jun 24, 2019, 10:28 AM Paul Mestemaker notifications@github.com wrote:

I like this suggestion. One thing to note, though, is that while this is possible with Postgres, it may not be supported on other popular RDBMS platforms.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/flexxnn/sequelize-auto-migrations/issues/52?email_source=notifications&email_token=AAVSCERAHZYJ57ZGQOFARZTP4BZRXA5CNFSM4HSIAOGKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYMA2SY#issuecomment-504892747, or mute the thread https://github.com/notifications/unsubscribe-auth/AAVSCEUZFJ74U3IUVRG7Z4DP4BZRXANCNFSM4HSIAOGA .

PaulMest commented 5 years ago

Looks like MySQL just started supporting Atomic DDL in 8.0. 👍