Reflect AST changes in Python 3.8.

flexxui / pscript

Python to JavaScript compiler

http://pscript.readthedocs.io

BSD 2-Clause "Simplified" License

256 stars 25 forks source link

Reflect AST changes in Python 3.8. #32

Closed serhiy-storchaka closed 4 years ago

serhiy-storchaka commented 5 years ago

There will be several changes in AST in Python 3.8.

ast.Num, ast.Str, ast.Bytes, ast.Ellipsis and ast.NameConstant are replaced with ast.Constant. (https://bugs.python.org/issue32892)

ast.Constant can be used since Python 3.6, it is just that ast.parse() didn't produce it.
Simplified AST for subscriptions. ast.Index is replaced with its value, ast.ExtSlice is replaced with ast.Tuple. (https://bugs.python.org/issue34822)

This change is not merged yet.

serhiy-storchaka commented 5 years ago

This is a fix for #31.

stonebig commented 5 years ago

no merge ?

almarklein commented 5 years ago

Python 3.8 is not released yet, and I've had to undo changes before, for things that were changed in alpha/beta, but removed in the final release. I'd rather wait until there is a final release (or an rc).

stonebig commented 5 years ago

Also, it's hard to contest a change/make it improved if nobody test it before rc.

icarito commented 4 years ago

I've tested the proposed change and can confirm that pscript works with Python 3.8 with this patch. I tested by directly deploying the commonast.py file to my installed pscript copy.

almarklein commented 4 years ago

Ok, let's do this :)

almarklein commented 4 years ago

also did a new release.

almarklein commented 4 years ago

I tweaked this some more in #39. And re-released (0.7.3)