search

flexxui / pscript

Python to JavaScript compiler
http://pscript.readthedocs.io
BSD 2-Clause "Simplified" License
256 stars 25 forks source link

Allow to rename functions starting with an uppercase letter #44

Closed maximlt closed 4 years ago

maximlt commented 4 years ago

Python functions declared with a name starting with an uppercase letter do not seem to be properly renamed. This bug appeared here: https://github.com/holoviz/holoviews/issues/4394

almarklein commented 4 years ago

Thanks, this makes a lot of sense!

Could you please make it an optional parameter, and fall back to the old behavior when it is not given or None? Then we can be confident that this change won't break any code that calls js_rename directly.

maximlt commented 4 years ago

@almarklein good point thanks a lot :)

almarklein commented 4 years ago

Thanks!