flexxui / webruntime

Launch HTML5 apps in the browser or a desktop-like runtime.
http://webruntime.readthedocs.io
BSD 2-Clause "Simplified" License
43 stars 10 forks source link

Running app runtime in fullscreen doesn't go over the taskbar #14

Closed beeb closed 4 years ago

beeb commented 5 years ago

Hey there!

I'm on Windows 10 and trying to show my flexx app in fullscreen. I tried to pass windowmode='fullscreen' or windowmode='kiosk' to my app.launch('app'...) call but I have a couple of issues:

Any help would be greatly appreciated! Thanks

almarklein commented 5 years ago

Hi @beeb I've transferred the issue to the appropriate library.

This is an interesting case, I've not used the windowmode feature a lot, to be honest, so this could be a bug. My initial feeling is that perhaps the size should not be specified in fullscreen/kiosk mode. Do you feel like looking into this yourself and perhaps make a PR? Otherwise I'll look into it when I have more time.

beeb commented 5 years ago

Hey! I'm not familiar with the code base and would lose a lot of time looking into this, so it's probably not efficient if I do it. I didn't set any size property in the case explained above, and this leads to the correct full-screen size, but only after minimizing and maximizing the window again. And in all cases the taskbar stays above it which is the main issue.

almarklein commented 5 years ago

I meant that the code in webruntime might need a change to not specify a width and height when fullscreen is requested.

almarklein commented 4 years ago

It's been a while :) I applied a possible fix. I'll do a release today. Please re-open if the problem persists.