fli-iam / shanoir-ng

Shanoir (SHAring iN vivO Imaging Resources)
GNU General Public License v3.0
19 stars 21 forks source link

ShanoirUploader: migrate swing GUI into Angular #2133

Open michaelkain opened 6 months ago

michaelkain commented 6 months ago

Hi @jcomedouteau, hi @pierrehenri-dauvergne, my idea is the following:

What I imagine as a first POC? use shanoir-uploader.jar as today and start it locally. Find a way to connect to it from the Angular web GUI, enter a query to the pacs, send it to shup.jar, that sends it to dcm4che arc, get the response, give it back to Angular and display it in the GUI.

With kind regards, Michael

jcomedouteau commented 5 months ago

Hi Michael, Pierre-Henry,

I like the idea, I'd love to get rid of swing !

I wonder if running shanoir-uploader as a server/service would be do-able in the context of hospitals. If we consider your use case, the user would be able to fetch information from all the pacs directly in shanoir from anywhere ? I'm not sure that DSI would agree on "publishing" a service from which we could fetch information. In the actual configuration, we control what we push to shanoir. Maybe we could keep this concept of shanoir-uploader that pushes data, but deploy a local microservice using angular that would be able to communicate locally and with shanoir. Another point is, on these computer, they generally have very old versions of explorer..

Maybe we can plan a meeting to discuss about it, I'm not really sure I understood well :)

Jean-Côme

michaelkain commented 5 months ago

Hi @jcomedouteau, thank you for your answer. Everybody would be happy to remove Swing GUI :-). My idea is not, to change the current kind of doing at all. So, nobody will have access to all pacs and only one user inside each hospital, will have access to his local data, only. Nothing more. We pseudonymize locally and then send the data out. So, the same machine, where ShUp runs today, runs a shanoir (micro)service, that does the same as ShUp today, except it does not have a GUI. The same user open his browser and connects via the web interface to "localhost:xxxxx", to be individually configured, where the local service runs. If the local service is not installed, nothing will happen. So, all remains the same, except the GUI shifts into browser and the user is already authenticated via web, that is the idea. So, where the Shanoir web GUI runs today, this should run. With kind regards, Michael