fli-iam / shanoir-ng

Shanoir (SHAring iN vivO Imaging Resources)
GNU General Public License v3.0
22 stars 22 forks source link

Merging of centers + equipments #2198

Open pierrehenri-dauvergne opened 6 months ago

pierrehenri-dauvergne commented 6 months ago

Some center are duplicated in shanoir, for instance: CHU Rennes and CHU Pontchaillou are the same but users don't always know. There are sometime two acquisition equipment with the same serialNumber in two different centers. The idea is to better use the information already present in the DICOMs to harmonize entities.

pierrehenri-dauvergne commented 5 months ago

The aim is to reduce the errors that user can make. Centers and acquisition equipment are closely linked. Users need to know which equipment to use and we need to know which equipment to keep

For instance, in prod we have such equipment:

Manufacturer GE MEDICAL SYSTEMS Manufacturer model DISCOVERY MR750w 3T (Mr) - GE MEDICAL SYSTEMS Model modality Mr Center CHU Rouen Serial Number 00000000 C4200438

Manufacturer GE MEDICAL SYSTEMS Manufacturer model DISCOVERY MR750w 3T (Mr) - GE MEDICAL SYSTEMS Model modality Mr Center CHU Rouen Serial Number 000000000 C4200438

Only difference in one '0'.

Other case:

Manufacturer GE MEDICAL SYSTEMS Manufacturer model DISCOVERY MR750w 3T (Mr) - GE MEDICAL SYSTEMS Model modality Mr Center CHU Bordeaux Serial Number 00000000M4166994

Manufacturer GE MEDICAL SYSTEMS Manufacturer model DISCOVERY MR750w 3T (Mr) - GE MEDICAL SYSTEMS Model modality Mr Center CHU Bordeaux Serial Number M4166994

00000000M4166994 vs M4166994, which is the one to keep ?

Another example:

Manufacturer Philips Medical Systems Manufacturer model Achieva-dStream 3T (Mr) - Philips Medical Systems Model modality Mr Center CHU Grenoble Serial Number 38235

Manufacturer Philips Manufacturer model Achieva dStream 3T (Mr) - Philips Model modality Mr Center CHU Grenoble Serial Number 38235

Manufacturer Philips Medical Systems Manufacturer model Achieva 3T (Mr) - Philips Medical Systems Model modality Mr Center CHU Grenoble Serial Number 38235

Is there a real difference between Philips and Philips Medical Systems? Is "dStream" an important information to keep?

Last but not least:

Manufacturer Philips Medical Systems Manufacturer model Achieva 3T (Mr) - Philips Medical Systems Model modality Mr Center CHU Michallon Serial Number 38014

Manufacturer Philips Medical Systems Manufacturer model Achieva 3T (Mr) - Philips Medical Systems Model modality Mr Center CHU Grenoble Serial Number 038014

Same city, but not the same hospital (Grenoble vs Michallon) and same serial number. Which one should we keep?

chomo-ofsep commented 1 month ago

If I may, I think this is an important question for the auto-creation of center, equipment and SC as well. I would say that the 0 before a letter can be removed (that is what I do for the OFSEP equipments).

Is there a real difference between Philips and Philips Medical Systems? Is "dStream" an important information to keep? I don't think it matters wether to keep Philips or Philips Medical Systems and I don't think dStream is an important information.

For the last one, it is surprising. Why would the same machine give different information ? I guess it is possible the machine has been moved. It might be interesting to ask the Application Specialists of the manufacturers to ask...